Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROD-1125 1118 config overrides query cookie window #4297

Merged
merged 8 commits into from
Oct 19, 2023
Merged

PROD-1125 1118 config overrides query cookie window #4297

merged 8 commits into from
Oct 19, 2023
+510 −40

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Oct 18, 2023 •
edited
Loading

Closes https://github.com/ethyca/fidesplus/issues/1119, https://github.com/ethyca/fidesplus/issues/1118, https://github.com/ethyca/fidesplus/issues/1120

Description Of Changes

Adds support for intaking override params via query param, cookie, or window object.

See https://ethyca.atlassian.net/wiki/spaces/EN/pages/2811854856/Docs+for+Mobile-Friendly+Fides.JS+Webview+Support for details of expected functionality

Code Changes

  • Updates init flow for both TCF and non-TCF versions of Fides.js such that specific params are overridden if detected in one of the 3 supported methods of passing those params into Fides.
  • Adds new way to pass in explicit query param and window obj in Cypress test
  • Adds Cypress tests for all permutations of setting override variables

Steps to Confirm

  • Run consent-banner-tcf.cy.ts e2e tests

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Oct 18, 2023 •
edited
Loading

Passing run #4692 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge df8d339 into 7b15ac1...
Project: fides Commit: fd1791d20a ℹ️
Status: Passed Duration: 01:11 💡
Started: Oct 19, 2023 3:29 PM Ended: Oct 19, 2023 3:30 PM

Review all test suite changes for PR #4297 ↗︎

allisonking
allisonking reviewed Oct 18, 2023
View reviewed changes
clients/fides-js/src/fides-tcf.ts Show resolved Hide resolved
clients/fides-js/src/lib/consent-types.ts Outdated Show resolved Hide resolved
clients/fides-js/src/lib/initialize.ts Outdated Show resolved Hide resolved
clients/privacy-center/cypress/e2e/consent-banner-tcf.cy.ts Outdated Show resolved Hide resolved
clients/privacy-center/cypress/e2e/consent-banner-tcf.cy.ts Show resolved Hide resolved
clients/privacy-center/cypress/support/commands.ts Show resolved Hide resolved
clients/fides-js/src/lib/consent-types.ts Show resolved Hide resolved
clients/fides-js/src/lib/initialize.ts Show resolved Hide resolved
clients/fides-js/src/lib/initialize.ts Outdated Show resolved Hide resolved
clients/fides-js/src/lib/consent-types.ts Outdated Show resolved Hide resolved
@eastandwestwind eastandwestwind mentioned this pull request Oct 19, 2023
Open
@rsilvery
Copy link
Contributor

@eastandwestwind any way to change the PR so it references "PROD-1125" in the title? That way I can automate the list of features to test, release notes, etc. Thank you!

@eastandwestwind eastandwestwind changed the title 1118 config overrides query cookie window PROD-1125 1118 config overrides query cookie window Oct 19, 2023
@eastandwestwind eastandwestwind mentioned this pull request Oct 19, 2023
Open
@eastandwestwind eastandwestwind force-pushed the 1118-config-overrides-query-cookie-window branch from 4bd13f2 to b1e1278 Compare October 19, 2023 13:40
allisonking
allisonking approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, thanks for making those changes, this is very neat!

@eastandwestwind eastandwestwind merged commit 8471288 into main Oct 19, 2023
10 checks passed
@eastandwestwind eastandwestwind deleted the 1118-config-overrides-query-cookie-window branch October 19, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NevilleS NevilleS NevilleS left review comments

@allisonking allisonking allisonking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eastandwestwind @rsilvery @NevilleS @allisonking